Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3466

Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables
......................................................................

IMPALA-3776: fix 'describe formatted' for Avro tables

For Avro tables the column information in the underlying database of the
Hive metastore can be different from what is specified in the
'avro.schema.url' file. HIVE-6308 aimed to improve upon this, but for
older tables the two don't necessarily align.

There are two possible cases:

1) Hive's underlying database contains a column, which is not present in
the Avro schema file. In this case we encounter a NullPointerException
in DescribeResultFactory.java#L189 when trying to lookup the column in
the internal table object.

2) The avro schema contains a column, which is not present in the
underlying database. In this case the column will not be displayed in
describe formatted.

I don't know how to automatically test this, but I verified this
manually by creating an Avro table with an external schema file in Hive.
This populated the underlying database with the column information. I
then either removed a column from the Avro schema file (case 1) or
cleared the column information from the "COLUMNS_V2" table in the
underlying database (case 2) and verified that the change fixed both
cases.

Change-Id: If7137b2ef163368b467898d40718f79911c3cf82
---
M fe/src/main/java/com/cloudera/impala/catalog/Column.java
M fe/src/main/java/com/cloudera/impala/catalog/Table.java
M fe/src/main/java/com/cloudera/impala/service/DescribeResultFactory.java
3 files changed, 28 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/66/3466/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7137b2ef163368b467898d40718f79911c3cf82
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker <l...@cloudera.com>

Reply via email to