Lars Volker has posted comments on this change. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables ......................................................................
Patch Set 1: (2 comments) Thanks for the comments. I will abandon this change and push a new version to cdh5-trunk. http://gerrit.cloudera.org:8080/#/c/3466/1/fe/src/main/java/com/cloudera/impala/catalog/Table.java File fe/src/main/java/com/cloudera/impala/catalog/Table.java: PS1, Line 392: ArrayList<Column> columns = Lists.newArrayList(getNonClusteringColumns()); : : for (Column column: colsByPos_.subList(0, numClusteringCols_)) { : columns.add(column); : } : return columns; > nit: This can be refactored to use getClusteringColumns() Done http://gerrit.cloudera.org:8080/#/c/3466/1/fe/src/main/java/com/cloudera/impala/service/DescribeResultFactory.java File fe/src/main/java/com/cloudera/impala/service/DescribeResultFactory.java: PS1, Line 185: // For some table formats (e.g. Avro) the column list in the table can differ from the : // one returned by the Hive metastore. To handle this we use the column list from the : // table. > I think we should confirm this behavior change with Marcel/Alex because thi Yes, Hive also shows the reconciled version, so prior to this change we actually returned a different result. However our results still differ in the comments for avro tables. I opened https://issues.cloudera.org/browse/IMPALA-3782 to track that. -- To view, visit http://gerrit.cloudera.org:8080/3466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7137b2ef163368b467898d40718f79911c3cf82 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
