Youwei Wang has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 32: (5 comments) http://gerrit.cloudera.org:8080/#/c/3081/30/be/src/util/bit-util-test.cc File be/src/util/bit-util-test.cc: Line 127: // CpuInfo::SSSE3 for SimdByteSwap::ByteSwapSSE_Unit; > CpuFlag can also be 0. Please indicate that in the comment Done http://gerrit.cloudera.org:8080/#/c/3081/30/be/src/util/bit-util.cc File be/src/util/bit-util.cc: > This was inline probably for performance reasons. Don't un-inline, please. Hi Jim. I am a little confused about which function you are talking about. In this file bit-util.cc, only the function BitUtil::ByteSwap has no "inline" modifier. But its original form doesn't have the "inline" modifier too: https://github.com/cloudera/Impala/blob/cdh5-trunk/be/src/util/bit-util.cc. I have also tried to inline it. However, this will cause linking errors like: ../../build/debug/exec/libExec.so: undefined reference to `impala::BitUtil::ByteSwap(void*, void const*, int)' http://gerrit.cloudera.org:8080/#/c/3081/30/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 32: > I think I asked you to put this in a details namespace inside Impala. Done Line 33: namespace impala { > Did you add this, or is this from rebasing? Done Line 251: > Please put these in a details namespace. Done -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 32 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <youwei.a.w...@intel.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Youwei Wang <youwei.a.w...@intel.com> Gerrit-HasComments: Yes
