Youwei Wang has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 33: (7 comments) > Today, Impala's official source is at https://github.com/cloudera/Impala/. > As of Monday, July 25, it will be at > https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git > > When that happens, you will have to re-send your changes to be > reviewed on gerrit, with some different git configuration. When the > new configuration is ready, a notice will go to > http://mail-archives.apache.org/mod_mbox/incubator-impala-dev/ > . If you aren’t subscribed to that list already, you should > subscribe now. Hi Jim. Thank you so much for posting such important notice! :) http://gerrit.cloudera.org:8080/#/c/3081/32/be/src/benchmarks/bswap-benchmark.cc File be/src/benchmarks/bswap-benchmark.cc: Line 46: /// ---------------------------------------------------------------------- > Templates declared in .h files must be defined in .h files: Done Line 91: > our code style uses lower_case_with_underscores for local variables: Done Line 145 > See above. Done Line 145 > See above. Done http://gerrit.cloudera.org:8080/#/c/3081/33/be/src/benchmarks/bswap-benchmark.cc File be/src/benchmarks/bswap-benchmark.cc: Line 47: /// OldImpala 1.224e+06 1X > This is gone, please remove it from benchmark. Done Line 68: // This function verifies the SIMD approach by comparing its output to the scalar > This is a test, not a benchmark, so belongs in test file. Done http://gerrit.cloudera.org:8080/#/c/3081/32/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 250: void ByteSwapScalarLoop(void* dst, const void* src, int len); > Not all of them, though, right? Just some of them? Hi Jim. Thanks for pointing out that. I have removed two declarations which are unnecessary here. The remained ones are indispensable to compile the codebase. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 33 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <youwei.a.w...@intel.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Youwei Wang <youwei.a.w...@intel.com> Gerrit-HasComments: Yes
