Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3991/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 343: context_->ClearStreams(); why is this under !advance_row_group_? If we did this here, then it seems like those lines you're adding to do this would be unnecessary. Line 373: if (context_->cancelled()) return Status::CANCELLED; why is this needed? won't the next GetNextInternal() notice this (inside CommitRows() -- though that's still a strange place for it too, but not this change). Line 513: *skip_row_group = true; doesn't this path have the same bug? -- To view, visit http://gerrit.cloudera.org:8080/3991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1e27a1517d09ccaabdae1492b7e1fbf661ae3e5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
