Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures ......................................................................
Patch Set 1: To answer the question of why the stress test hit this: the query was cancelled (I noticed that while debugging it last week but couldn't quite complete the whole picture). The cancellation was noticed eventually by HdfsParquetScanner::AssembleCollection() which eventually bubbles 'continue_execution == false' up the stack to the loop in AssembleRows(), causing this bug. So, it may indeed be a good idea to add some debug actions there for debug builds. -- To view, visit http://gerrit.cloudera.org:8080/3991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1e27a1517d09ccaabdae1492b7e1fbf661ae3e5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: No
