Who wrote the original document? There are several items on there that are the exact opposite of what we do (basically everything in the 'Classes' section).
I would prefer to remove that entire section. Anyone against that? On Fri, Sep 2, 2016 at 9:59 AM, Tim Armstrong <[email protected]> wrote: > Yes, several things are completely wrong. E.g. we never use c-style casts. > > On Fri, Sep 2, 2016 at 9:38 AM, Jim Apple <[email protected]> wrote: > >> I left a comment on the page - I'm not sure how much these reflect our >> actual current practice. >> >> On Fri, Sep 2, 2016 at 9:36 AM, Lars Volker <[email protected]> wrote: >> > After some confusion in reviews about how to format code I moved our >> > internal C++ Style Guide wiki page to the Apache wiki and updated all >> links >> > in it. You can find it here: >> > >> > https://cwiki.apache.org/confluence/pages/viewpage. >> action?pageId=65868536 >> > >> > At some point in time someone seems to have started a list of pro and >> cons, >> > some of which are worded rather negative. Do we want to revisit those >> > comments or the style guide even? >> > >> > I'm looking forward to any feedback. Thanks, Lars >>
