Hi, > - LICENSE need to mention license of Maven Wrapper
As Lei Rui and Justin pointed out some issues, I find it is my fault that some changes are not cherry-picked from rel/0.8 to master and rel/0.9. So, we need to scan the commitlogs between release-0.8.0 to release-0.8.1 and cherry-pick needed commitlogs to rel/0.9 and the master branch. @Jialin > - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say I checked [1], it should be " Copyright 2001-2019 The Apache Software Foundation" > - NOTICE is missing information from from the common NOTICE file [1][3] Hi, @Justin, are you meaning the following guidance? " Copyright notifications which have been relocated from source files (rather than removed) must be preserved in NOTICE. However, elements such as the copyright notifications embedded within BSD and MIT licenses need not be duplicated in NOTICE -- it suffices to leave those notices in their original locations." > large number of files have the incorrect ASF header. There should be no "Copyright © 2019 Apache IoTDB(incubating) If you are using IDEA to generate the ASF header on a new file, please fix them to avoid the same error in the future... > It is still unclear where the "Maven Wrapper” code comes from and the file is missing a license header. Hi Justin, I have added the ASF header on release-0.8.1, but forgot to cherry-pick the modifications to the master... > - There an unexpected binary file in the release [4] (maven-wrapper.jar) @Jialin, help me to add a step "rm .mvnw/wrapper/*.jar" on the Chinese Guidance on Apache Confluence. [1] https://github.com/apache/commons-collections/blob/master/NOTICE.txt [3] http://www.apache.org/dev/licensing-howto.html#alv2-dep Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院
