Hi, >> - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say > > I checked [1], it should be " Copyright 2001-2019 The Apache Software > Foundation”
Probably you just want "Copyright 2019” I think, as they are the only years that IoTDB have made a release. >> - NOTICE is missing information from from the common NOTICE file [1][3] > > Hi, @Justin, are you meaning the following guidance? " Copyright > notifications which have been relocated from source files (rather than > removed) must be preserved in NOTICE. However, elements such as the > copyright notifications embedded within BSD and MIT licenses need not be > duplicated in NOTICE -- it suffices to leave those notices in their > original locations.” No, it’s this: "If the dependency supplies a NOTICE file, its contents must be analyzed and the relevant portions bubbled up into the top-level NOTICE file." > Hi Justin, I have added the ASF header on release-0.8.1, but forgot to > cherry-pick the modifications to the master… I’m not sure that is the right solution. Was this file developed at the ASF or elsewhere? My understanding is that it come from a 3rd party and thus should not have an ASF header but a 3rd party one. Be sure to mention what license it is under in the LICENSE file as well. Thanks, Justin
