-1 (binding) 

There is a "jar" file in the build.

Chris


Am 14.11.19, 23:41 schrieb "Justin Mclean" <[email protected]>:

    Hi,
    
    -`1 (binding) due to maven wrapper issue, LICENSE and NOTICE issues, header 
issues and compiled code in the release.
    
    Some of these have been brought up before and occurred before, what can be 
done to stop them happening again?
    
    As I also suggested before it’s best to use the work in progress DISCLAIMER 
[2] until you are sure that everything has been sorted.
    
    I checked:
    - incubating in name
    - signatures and hashes fine
    - DISCLAIMER exists
    - LICENSE need to mention license of Maven Wrapper
    - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say 
    - NOTICE is missing information from from the common NOTICE file [1][3]
    - A large number of files have the incorrect ASF header. There should be no 
"Copyright © 2019 Apache IoTDB(incubating) ([email protected])” notice in 
the files.
    - There an unexpected binary file in the release [4]
    - Can compile from source (with and without the mavin wrapper)
    
    It is still unclear where the "Maven Wrapper” code comes from and the file 
is missing a license header. How is someone to know how this files is licensed 
or that the file is even under a compatible license?
    
    Thanks,
    Justin
    
    1. https://github.com/apache/commons-collections/blob/master/NOTICE.txt
    2. https://incubator.apache.org/policy/incubation.html#disclaimers
    3. http://www.apache.org/dev/licensing-howto.html#alv2-dep
    4 ./.mvn/wrapper/maven-wrapper.jar
    
    

Reply via email to