Hi,

+1 for refactor the modules.


I ran into the same problem during the compilation.


Thanks for bring up this discussion Xiangdong!




Best,
Dawei Liu
On 07/2/2020 17:16,jincheng sun<sunjincheng...@gmail.com> wrote:
+1 for the proposal, Thanks for bring up this discussion Xiangdong!

Best,
Jincheng


Julian Feinauer <j.feina...@pragmaticminds.de> 于2020年6月29日周一 下午3:41写道:

Hi,

good point, I agree.

Julian

Am 29.06.20, 09:03 schrieb "Xiangdong Huang" <saint...@gmail.com>:

Hi,

we could also consider migrating to protobuf and grpc then as I like
their maven plugin and it really works flawlessly (and downloads the
protoc
automagically).

I think we can postpone the discussion about the replacement after the
cluster module is merged... It will be a disaster if we do that now.

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

黄向东
清华大学 软件学院


Julian Feinauer <j.feina...@pragmaticminds.de> 于2020年6月29日周一 下午2:58写道:

Hi,

we could also consider migrating to protobuf and grpc then as I like
their
maven plugin and it really works flawlessly (and downloads the protoc
automagically).

But I would also be fine with extracting it.

Julian

Am 29.06.20, 08:30 schrieb "Xiangdong Huang" <saint...@gmail.com>:

Hi,

I suffer from this issue for a long time:

When I checkout to some branch where the version is
xxx-SNAPSHOT and
want
to run the source codes on the branch in IDE (IDEA), I have to
run `mvn
generate-sources` first to generate the thrift and antlr4 codes,
otherwise,
the IDEA will say some classes are not found.

However, if the xxx-SNAPSHOT.jar is not on my local maven repo,
`mvn
generate-sources` will fail because the dependency `tsfile.jar`
is not
found...
Then I have to run `mvn package -DskipTests` and waste several
minutes
for
waiting the compiler.

I'd like to extract the .thrift file and .g4 file separately
into two
new
modules (without any other module dependencies except for thrift
and
antlr), so that we can run `mvn generate-sources` successfully
and save
time..

how do you think?

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

黄向东
清华大学 软件学院




Reply via email to