Hi,

+1 from PMC


[✔️]download staged artifacts. Check their signature and hashes.
[✔️]NOTICE file "Copyright 2018-2021 The Apache Software Foundation”. 
[✔️]Could run with the following statements

SET STORAGE GROUP TO root.turbine;
CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=DOUBLE, ENCODING=PLAIN;
insert into root.turbine.d1(timestamp,s0) values(1,0);
insert into root.turbine.d1(timestamp,s0) values(1,1);
insert into root.turbine.d1(timestamp,s0) values(1,2);
select * from root;


Minor issue:
[❕]There are still "incubator" keyword in files: grep -r incubator ./*
[❕]build from source : ./mvn.sh install -DskipTests
        "./mvnw.sh clean install" failed at client-py due to not ignore the 
license check of thrift-generated code
[❕]Search for SNAPSHOT references: find . -type f -name 'pom.xml' -exec grep -l 
"SNAPSHOT" {} \;
        ./code-coverage/pom.xml


Dawei Liu
On 04/9/2021 11:40,Jialin Qiao<qiaojia...@apache.org> wrote:
Hi,

+1 (PMC could binding)

The source release:
LICENSE and NOTICE [ok]
signatures and hashes [ok]
All files have ASF header [ok]

The binary distribution:
LICENSE and NOTICE [ok]
signatures and hashes [ok]
Could run with the following statements [ok]

SET STORAGE GROUP TO root.turbine;
CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=DOUBLE, ENCODING=GORILLA;
insert into root.turbine.d1(timestamp,s0) values(1,1);
insert into root.turbine.d1(timestamp,s0) values(2,2);
insert into root.turbine.d1(timestamp,s0) values(3,3);
select * from root;

Minor issue:
"./mvnw.sh clean install" failed at client-py due to not ignore the license
check of thrift-generated code


Thanks,
—————————————————
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院


Houliang Qi <neuyi...@163.com> 于2021年4月9日周五 上午10:09写道:

Hi,

+1  from committer

But only one issue not sure, the org.checkerframework:checker-qual:2.0.0
have two licenses: GPL2.0 and MIT, I not sure apache 2.0 is compatible with
it or not.

I checked the following operations on macOS 10.15.4 and jdk 1.8

The source release:

Check third party dependencies [NOT SURE]
LICENSE and NOTICE [ok]
signatures and hashes [ok]
All files have ASF header [ok]
could compile from source: ./mvnw.sh clean install [ok]

The binary distribution:
LICENSE and NOTICE [ok]
signatures and hashes [ok]
Could run with the following statements [ok]

SET STORAGE GROUP TO root.turbine;
CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=DOUBLE,
ENCODING=GORILLA;
insert into root.turbine.d1(timestamp,s0) values(1,1);
insert into root.turbine.d1(timestamp,s0) values(2,2);
insert into root.turbine.d1(timestamp,s0) values(3,3);
select * from root;



Thanks,
---------------------------------------
Houliang Qi
BONC, Ltd


On 04/6/2021 13:33,Xiangdong Huang<saint...@gmail.com> wrote:
Hi all,

Big news! 0.12.0 RC1 is ready.

Apache IoTDB 0.12.0 introduces many new features, like the new TsFile
structure (version: 000002), the User-Define-Function, and the cluster
module.  Welcome to validate the release and have a try.

Form 0.12.0 on, we separate the binary release file into several: the
server, the cluster, the cli, the cpp-client-lib, the python (through
Pypi), the grafana-connector, and all-in-one.
Other connectors, like hive, hadoop, spark and zeppelin connectors are not
released as independent binary files.

You can get the main changes from [5].

Apache IoTDB 0.12.0 has been staged under [2] and it’s time to vote
on accepting it for release.  All Maven artifacts are available under [1].


Voting will be open for 72hr.
A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.

Release tag: v0.12.0
Hash for the release tag: 06adff7fad83c324aaeb90160766ecfd0bd2b84a

Before voting +1, PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases.[3]

You can achieve the above by following [4].

[ ]  +1 accept (indicate what you validated)
[ ]  -1 reject (explanation required)

[1] https://repository.apache.org/content/repositories/orgapacheiotdb-1059
[2] https://dist.apache.org/repos/dist/dev/iotdb/0.12.0/rc1
[3] https://www.apache.org/dev/release.html#approving-a-release
[4]

https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release
[5]
https://dist.apache.org/repos/dist/dev/iotdb/0.12.0/rc1/RELEASE_NOTES.md
[6] https://dist.apache.org/repos/dist/dev/iotdb/KEYS

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

黄向东
清华大学 软件学院

Reply via email to