Hi Chris, > Also did I see that for some reason we’re copying the python generated code > into the mlnode module … what’s that for?
Mlnode is a new module in progress for providing interfaces for machine learning. > It looks as if the generated go code isn’t used anywhere … shouldn’t we then > also remove the go-code generation invocation? The generated go code is for iotdb-go-client https://github.com/apache/iotdb-client-go. Currently, we copy the generated code to that repo manually to update the thrift interface. We can find another better way to do it. Haonan > On Aug 15, 2023, at 9:33 PM, Christofer Dutz <[email protected]> > wrote: > > Hi all, > > So, after I’m now quite happy about the untangled Java part, and while going > through the documentation, I noticed some things: > > We’re currently generating the python and go code as part of the build of the > protocol modules. > Then in the client-py, we copy that code around. > Wouldn’t it be better if we simply generated the code in the client-py module > directly? > > Also did I see that for some reason we’re copying the python generated code > into the mlnode module … what’s that for? > > It looks as if the generated go code isn’t used anywhere … shouldn’t we then > also remove the go-code generation invocation? > > Chris
