ok..., if so, I think it's really nice. On Wed, Jun 5, 2024 at 8:28 PM Christofer Dutz <christofer.d...@c-ware.de> wrote:
> Also is the settings currently done that it only skips any tests in > non-master branches … so if there’s a PR on a branch, that will be > optimized, but every commit going back to master should have all tests run. > > Chris > > > Von: Christofer Dutz <christofer.d...@c-ware.de> > Datum: Mittwoch, 5. Juni 2024 um 14:22 > An: dev@iotdb.apache.org <dev@iotdb.apache.org> > Betreff: AW: [DISCUSS] GH Actions optimizations > Well even with the re-run option still failures get counted and a > dashboard like this: > > https://ge.apache.org/scans/tests?search.rootProjectNames=*IoTDB*&search.timeZoneId=Europe%2FBratislava&tests.sortField=FLAKY > Is a lot better than having to continuously go back to your PRs and click > on “re-run failed tests” > > Chris > > Von: Yuan Tian <jackietie...@gmail.com> > Datum: Mittwoch, 5. Juni 2024 um 03:06 > An: dev@iotdb.apache.org <dev@iotdb.apache.org> > Betreff: Re: [DISCUSS] GH Actions optimizations > Hi Chris, > > That's really good news. About the `surefire` part, I think we need to > discuss more about it because some of the previously failed tests have > indeed helped us discover concurrency issues in IoTDB. I am concerned that > doing this might reduce the likelihood of exposing such bugs. > > > Best regards, > -------------------- > Yuan Tian >
