Hi,
I have also thought about this before.
The main issue that I see is that some font/svg icons prescribe usage of
specific HTML elements. For example some say you should use <i
class="...">, others <span class="...">, FontAwesome also has more complex
HTML structure for stacked icons (see http://fontawesome.io/examples/).
At the moment we use <span> and there is no support for complex HTML
structure.
We can rename 'cssClassFa' in annotations to 'fontIcon' to make it more
generic.
Its value though will have to be an Icon interface that knows how to render
itself.
E.g. FAIcon will render as <span> with predefined CSS class "fa":
fontIcon = new FAIcon("circle")
will produce: <span class="fa fa-circle"></span>
Just thinking out load.
On Fri, Dec 12, 2014 at 1:34 PM, GESCONSULTOR <[email protected]>
wrote:
> Is not this too concrete?
>
> Could it be specified by means of a more generic mechanism?
>
> I find too specific to have an annotation property for a concrete set of
> icons. There are others currently also used (like icons8, etc) that could
> be also referred.
>
> Perhaps a mechanism a bit more generic could instead be used? Or at least
> an annotation field name not referring on its name the "font awesome"
> initials?
>
> HTH,
>
> Oscar
>
>
> > El 12/12/2014, a las 11:13, Dan Haywood (JIRA) <[email protected]>
> escribió:
> >
> > Dan Haywood created ISIS-974:
> > --------------------------------
> >
> > Summary: Provide the ability to associate font-awesome icons
> with properties
> > Key: ISIS-974
> > URL: https://issues.apache.org/jira/browse/ISIS-974
> > Project: Isis
> > Issue Type: Improvement
> > Components: Core, Viewer: Wicket
> > Affects Versions: core-1.7.0, viewer-wicket-1.7.0
> > Reporter: Dan Haywood
> > Assignee: Dan Haywood
> > Priority: Minor
> > Fix For: viewer-wicket-1.9.0, core-1.9.0
> >
> >
> > ie as per http://fortawesome.github.io/Font-Awesome/examples/#bootstrap
> >
> > using:
> >
> > @PropertyLayout(
> > cssClassFa="fa fa-fw fa-envelope-o"
> > )
> > public String getEmailAddress() { ... }
> >
> > etc.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.4#6332)
>
