[ http://issues.apache.org/jira/browse/JCR-442?page=comments#action_12423670 ] Nicolas Toper commented on JCR-442: -----------------------------------
Hi Jukka, Here are my answers :p a/ Done. Maybe I should put in the constructor of Backup the session since it's shared by a few classes. What do you think? I had to look for the default workspace to get a System Session. Can we assume it's always there? b/ It's actually already the case. I just needed to cast Workspace to WorkspaceImpl. I corrected the code on my side. c/ Maybe we should add an external tool session instead of sharing a session with JR "internals". What do you think? d/ This is what I did first, but I use it in BackupConfigurationParser and it is already used in RepositoryConfigurationParser. It is why it's there. (for now I don't use the PM but this might change). I suggest to leave a TODO on this point and see if it's still needed there at the end of the project. Do you agree? e/ At first I put it in my backup class and then I thought it could be useful to others. It's why it's there. As you can see, I can put it in my backup class if needed but this functionnality can be needed also by other application. What do you think? f/ Done. g/ The test case is renamed with the right header. h/ I have checked the tabs issue *also* in my Jackrabbit patch :p > Implement a backup tool > ----------------------- > > Key: JCR-442 > URL: http://issues.apache.org/jira/browse/JCR-442 > Project: Jackrabbit > Issue Type: New Feature > Reporter: Jukka Zitting > Attachments: jackrabbit-1.patch.txt, patch, patch-backup-060716.txt, > patch-backup-060719.txt, patch-backup-060725.txt, patch-backup-060726.txt, > patch-jackrabbit-060716.txt, patch-jackrabbit-060718.txt, > patch-jackrabbit-060725.txt, patch-jackrabbit-060726.txt, patch.txt, > patch.txt, patch.txt, patch.txt > > > Issue for tracking the progress of the Google Summer of Code project assigned > to Nicolas Toper. The original project requirements are: > "Implement a tool for backing up and restoring content in an Apache > Jackrabbit content repository. In addition to the basic content hierarchies, > the tool should be able to efficiently manage binary content, node version > histories, custom node types, and namespace mappings. Incremental or > selective backups would be a nice addition, but not strictly necessary." -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira