[
https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670721#action_12670721
]
angela commented on JCR-1963:
-----------------------------
with just having quickly looked at the code, i would assume that this shouldn't
do too much harm (though it's not what i would call perfect). in the worst case
(prop wasn't modified) this would generate a superfluous internal
notification...
if, however, we would also address issue #JCR-1012 there was (most probably)
another way to determine if a property has changed (thinking of some sort of
modcnt or rev. number)... this could be an more elegant approach...
anyway: michael, can you take care of this one? thanks
> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
> Key: JCR-1963
> URL: https://issues.apache.org/jira/browse/JCR-1963
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-jcr2spi
> Reporter: Michael Dürig
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should
> alway consider two binary values to be different. The current implementation
> compares two binary values with equals(). An implementation will in general
> have to do a byte by byte comparison of both values. This is most likely
> always more expensive than considering the values different right from the
> start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
