[ 
https://issues.apache.org/jira/browse/JCR-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676636#action_12676636
 ] 

Michael Dürig commented on JCR-1963:
------------------------------------

Further investigation shows that

a) property diffing is sometimes done even if the result is not used by the 
caller.

b) property diffing occurs very frequently when the same session is accessed 
concurrently from within different threads.

I will fix a) in jcr2spi. Case b) is invalid since it's the client's 
responsibility to synchronize access to sessions. 

> Determination of property state difference should skip binary values
> --------------------------------------------------------------------
>
>                 Key: JCR-1963
>                 URL: https://issues.apache.org/jira/browse/JCR-1963
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi
>            Reporter: Michael Dürig
>
> o.a.j.jcr2spi.state.PropertyState.diffPropertyData, PropertyData) should 
> alway consider two binary values to be different. The current implementation 
> compares two binary values with equals(). An implementation will in general 
> have to do a byte by byte comparison of both values. This is most likely 
> always more expensive than considering the values different right from the 
> start. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to