[
https://issues.apache.org/jira/browse/JCR-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931567#comment-13931567
]
Dominique Pfister edited comment on JCR-3729 at 3/12/14 9:17 AM:
-----------------------------------------------------------------
[~shgupta], there are a couple of issues with your patch:
- Apparently, you restructured the files you touched, so e.g. S3Backend looks
like it completely changed, while instance variables and methods (e.g. write)
only moved to another location. This makes it very hard to review the changes,
so please try to change as few lines as possible, and avoid changing existing
code such as:
{code}
- if (!prevObjectListing.isTruncated()) {
- break;
- }
+ if (!prevObjectListing.isTruncated()) break;
{code}
for the latter version doesn't adhere to the coding conventions.
- Then you deleted a couple of production (InMemoryBackend) and test files
(TestCaseBase, TestInMemDs, TestInMemDsCacheOff), are they no longer required?
- Finally, you're adding a system property in TestAll:
{code}
+ System.setProperty(
+ TestCaseBase.CONFIG,
+
"C:/sourceCodeGit/granite-modules/temp-crx-ext-s3/crx-ext-s3/src/test/resources/aws.properties");
{code}
I doubt this will work in a Non-Windows environment.
was (Author: dpfister):
[~shgupta], there are a couple of issues with your patch:
- Apparently, you restructured the files you touched, so e.g. S3Backend looks
like it completely changed, while instance variables and methods (e.g. write)
only moved to another location. This makes it very hard to review the changes,
so please try to change as few lines as possible, and avoid
changing existing code such as:
{code}
- if (!prevObjectListing.isTruncated()) {
- break;
- }
+ if (!prevObjectListing.isTruncated()) break;
{code}
for the latter version doesn't adhere to the coding conventions.
- Then you deleted a couple of production (InMemoryBackend) and test files
(TestCaseBase, TestInMemDs, TestInMemDsCacheOff), are they no longer required?
- Finally, you're adding a system property in TestAll:
{code}
+ System.setProperty(
+ TestCaseBase.CONFIG,
+
"C:/sourceCodeGit/granite-modules/temp-crx-ext-s3/crx-ext-s3/src/test/resources/aws.properties");
{code}
I doubt this will work in a Non-Windows environment.
> S3 Datastore optimizations
> --------------------------
>
> Key: JCR-3729
> URL: https://issues.apache.org/jira/browse/JCR-3729
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: 2.7.4
> Reporter: Shashank Gupta
> Fix For: 2.7.5
>
> Attachments: JCR-3729.patch
>
>
> Following optimizations can be done on S3 Datastore based on customer's/S3
> engineers feedback.
> * Use object keys to create partitions in S3 automatically.
> * Multi-threaded migration of binary files from FileSystem to S3 datastore
> * Externalize S3 endpoints.
> * Asynchronous upload file to S3
> * Slow Startup Of Instance
--
This message was sent by Atlassian JIRA
(v6.2#6252)
