[ 
https://issues.apache.org/jira/browse/JCR-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931577#comment-13931577
 ] 

Shashank Gupta edited comment on JCR-3729 at 3/12/14 9:33 AM:
--------------------------------------------------------------

>Apparently, you restructured the files you touched, so e.g. S3Backend looks 
>like it completely changed, while instance variables and methods (e.g. write) 
>only moved to another location
Yes. It is more structured . For e.g. like public method are now followed by 
private methods.  since changes are too large i advise to look at full source 
code. 

> or the latter version doesn't adhere to the coding conventions.
yes i think eclipse didn't format it. I will change it. 

>Then you deleted a couple of production (InMemoryBackend) and test files 
>(TestCaseBase, TestInMemDs, TestInMemDsCacheOff), are they no longer required?
They are re-factored  jackrabbit-data. I missed to add files to patch. added in 
patch version 1. 

>finally, you're adding a system property in TestAll:
left over from initial testing. removed  in patch version 1. 


was (Author: shgupta):
>Apparently, you restructured the files you touched, so e.g. S3Backend looks 
>like it completely changed, while instance variables and methods (e.g. write) 
>only moved to another location
Yes. It is more structured . For e.g. like public method are now followed by 
private methods.  since changes are too large i advice to look at full source 
code. 

> or the latter version doesn't adhere to the coding conventions.
yes i think eclipse didn't format it. I will change it. 

>Then you deleted a couple of production (InMemoryBackend) and test files 
>(TestCaseBase, TestInMemDs, TestInMemDsCacheOff), are they no longer required?
They are re-factored  jackrabbit-data. I missed to add files to patch. added in 
patch version 1. 

>finally, you're adding a system property in TestAll:
left over from initial testing. removed  in patch version 1. 

> S3 Datastore optimizations
> --------------------------
>
>                 Key: JCR-3729
>                 URL: https://issues.apache.org/jira/browse/JCR-3729
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.7.4
>            Reporter: Shashank Gupta
>             Fix For: 2.7.5
>
>         Attachments: JCR-3729.patch, JCR-3729_V1.patch
>
>
> Following optimizations can be done on S3 Datastore based on customer's/S3 
> engineers feedback.
> *  Use object keys to create partitions in S3 automatically.
> *  Multi-threaded migration of binary files from FileSystem to S3 datastore
> *  Externalize S3 endpoints.
> *  Asynchronous upload file to S3
> *  Slow Startup Of Instance



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to