fabriziofortino commented on code in PR #1071:
URL: https://github.com/apache/jackrabbit-oak/pull/1071#discussion_r1318385118
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneDocumentMaker.java:
##########
@@ -315,6 +313,38 @@ protected boolean indexTypeOrderedFields(Document doc,
String pname, int tag, Pr
}
return fieldAdded;
}
+
+ protected static BytesRef checkTruncateLength(String prop, String value,
String path, int maxLength) {
+ log.trace("Property {} at path:[{}] has value {}", prop, path, value);
+
+ BytesRef ref = new BytesRef(value);
+ if (ref.length <= maxLength) {
+ return ref;
+ }
+ log.info("Truncating property {} at path:[{}] as length after encoding
{} is > {} ",
+ prop, path, ref.length, maxLength);
+ int end = maxLength - 1;
+ // skip over tails of utf-8 multi-byte sequences (up to 3 bytes)
+ while ((ref.bytes[end] & 0b11000000) == 0b10000000) {
+ end--;
+ }
+ // remove one head of a utf-8 multi-byte sequence (at most 1)
+ if ((ref.bytes[end] & 0b11000000) == 0b11000000) {
+ end--;
+ }
+ byte[] bytes2 = Arrays.copyOf(ref.bytes, end + 1);
Review Comment:
for clarity, I would use something like `truncatedBytes` instead of `bytes2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
