amit-jain commented on code in PR #1071:
URL: https://github.com/apache/jackrabbit-oak/pull/1071#discussion_r1318388488
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneDocumentMaker.java:
##########
@@ -315,6 +313,38 @@ protected boolean indexTypeOrderedFields(Document doc,
String pname, int tag, Pr
}
return fieldAdded;
}
+
+ protected static BytesRef checkTruncateLength(String prop, String value,
String path, int maxLength) {
Review Comment:
Hmm...I think this takes the refactoring too far and in fact makes
readability harder. Generally if there was a need for reuse for some of the
sub methods it would have made sense. Explanation of the code can happen
through documentation as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
