nfsantos commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366748885


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##########
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws 
IOException, CommitFailedExcept
     }
 
     public void reindex() throws CommitFailedException, IOException {
+        log.info("[TASK:INDEXING_JOB:START] Starting indexing job");

Review Comment:
   The first idea that comes to my mind for `ingestion` is the upload phase. 
And so far we have been using indexing to refer to the actual reindex 
operation, so it would be a change of terminology. But I'm ok with changing the 
name and introducing a new term, if no one has a better proposal.
   
   The changes to replace the current INDEXING references by INGESTION are 
small on the Oak side. But users of Oak that are already parsing the logs for 
the term INGESTION would have to be modified, but that is probably not much 
work. Since this is a recent feature, it should not be an issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to