nfsantos commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366978776


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##########
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws 
IOException, CommitFailedExcept
     }
 
     public void reindex() throws CommitFailedException, IOException {
+        log.info("[TASK:INDEXING_JOB:START] Starting indexing job");

Review Comment:
   I have change the name used for the whole process to `FULL_INDEX_CREATION`. 
I did not change the name of the upload phase because this is derived 
automatically from existing code:
   
   
https://github.com/apache/jackrabbit-oak/blob/abcfb39909afbaf58b436a9ad6e34998e864a833/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/importer/IndexImporter.java#L131
   
   Here is an example of how the metric messages look like currently for the 
phases after building the FFS:
   ```
   15:42:35.440 [main] INFO  o.a.j.o.i.i.d.DocumentStoreIndexer - 
[TASK:INDEXING:START] Starting indexing
   16:22:26.236 [main] INFO  o.a.j.o.i.i.d.DocumentStoreIndexer - 
[TASK:INDEXING:END] Metrics: {"duration":"00:39:50","durationSeconds":2390}
   16:22:26.236 [main] INFO  o.a.j.o.i.i.d.DocumentStoreIndexer - 
[TASK:MERGE_NODE_STORE:START] Starting merge node store
   16:22:26.237 [main] INFO  o.a.j.o.i.i.d.DocumentStoreIndexer - 
[TASK:MERGE_NODE_STORE:END] Metrics: {"duration":"00:00:00","durationSeconds":0}
   16:23:46.397 [main] INFO  o.a.j.o.p.i.importer.IndexImporter - 
[TASK:SWITCH_LANE:START]
   16:23:46.451 [main] INFO  o.a.j.o.p.i.importer.IndexImporter - 
[TASK:SWITCH_LANE:END] Metrics: {"duration":"00:00:00","durationSeconds":0}
   16:23:46.452 [main] INFO  o.a.j.o.p.i.importer.IndexImporter - 
[TASK:IMPORT_INDEX_DATA:START]
   16:29:48.386 [main] INFO  o.a.j.o.p.i.importer.IndexImporter - 
[TASK:IMPORT_INDEX_DATA:END] Metrics: 
{"duration":"00:06:01","durationSeconds":361}
   16:29:48.387 [main] INFO  o.a.j.o.p.i.importer.IndexImporter - 
[TASK:BRING_INDEX_UPTODATE:START]
   16:31:23.963 [main] INFO  o.a.j.o.p.i.importer.IndexImporter - 
[TASK:BRING_INDEX_UPTODATE:END] Metrics: 
{"duration":"00:01:35","durationSeconds":95}
   16:31:23.964 [main] INFO  o.a.j.o.p.i.importer.IndexImporter - 
[TASK:RELEASE_CHECKPOINT:START]
   16:31:23.969 [main] INFO  o.a.j.o.p.i.importer.IndexImporter - 
[TASK:RELEASE_CHECKPOINT:END] Metrics: 
{"duration":"00:00:00","durationSeconds":0}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to