reschke commented on code in PR #348:
URL:
https://github.com/apache/jackrabbit-filevault/pull/348#discussion_r1709823732
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -989,8 +989,17 @@ private void removeReferences(@NotNull Node node) throws
ReferentialIntegrityExc
VersioningState vs = new VersioningState(stack, node);
Node updatedNode = null;
Optional<String> identifier = ni.getIdentifier();
+
+ String nodeUUID = null;
+ try {
+ nodeUUID = node.getUUID();
Review Comment:
Yes, but this is the simplest way to find out whether the node is
referenceable. The other things I tried all require a lot of work with checking
node types.
FWIW, the deprecation of `getUUID()` IMHO was incorrect, because these two
have different semantics for non-referenceable nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
