kwin commented on code in PR #348:
URL:
https://github.com/apache/jackrabbit-filevault/pull/348#discussion_r1711338418
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -989,8 +989,19 @@ private void removeReferences(@NotNull Node node) throws
ReferentialIntegrityExc
VersioningState vs = new VersioningState(stack, node);
Node updatedNode = null;
Optional<String> identifier = ni.getIdentifier();
+
+ boolean isUuidProtected = false;
+ if (!
session.getRepository().getDescriptor(Repository.REP_NAME_DESC).contains("Oak"))
{
+ // workaround for non-Oak repos that may not be able to add
+ // mixin:referencable *after* setting jcr:uuid
+ isUuidProtected = true;
Review Comment:
The original idea was to encapsulate impl specific differences in
https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/spi/ServiceProvider.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
