kwin commented on code in PR #378:
URL:
https://github.com/apache/jackrabbit-filevault/pull/378#discussion_r2225876166
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/config/DefaultWorkspaceFilter.java:
##########
@@ -264,6 +273,11 @@ public boolean covers(String path) {
@Override
public boolean includesProperty(String propertyPath) {
+ if (skipFilterChecksOnImport) {
+ // skip the filter checks if requested; assume that the package
only includes content
+ // which matches the filters.
+ return true;
Review Comment:
But isn’t this also called for properties contained in existing nodes but
not contained in the package? That would make using this flag break merge
properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
