joerghoh commented on code in PR #378:
URL:
https://github.com/apache/jackrabbit-filevault/pull/378#discussion_r2333339660
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/config/DefaultWorkspaceFilter.java:
##########
@@ -241,6 +241,10 @@ public void setSkipFilterChecksOnImport(boolean
skipFilterChecksOnImport) {
this.skipFilterChecksOnImport = skipFilterChecksOnImport;
}
+ public boolean getSkipFilterChecksOnImport() {
Review Comment:
I tried to backtrack from the constructor of the DocViewImporter, which
methods would need to be changed, and the list is getting long; where annotated
with ```...``` I stopped (line numbers might not be 100% accurate, as my
eclipse behaves sometimes a bit strange
(https://github.com/eclipse-platform/eclipse.platform.ui/issues/3039).
But it shows, that passing this parameter through the entire call chain(s)
would be quite an effort, and for that reason I augmented the
DefaultWorkspaceFilter.
```
DocViewImporter.java (l249)
-> AbstractArtifactHandler:importDocView (l170)
-> AbstractArtifactHandler:importDocView (l166)
-> FileArtifactHandler:accept (l231)
-> ...
-> FileArtifactHandler:importDocView (l236)
-> FileArtifactHandler::accept (l231) -> see above
-> GenericArtifactHandler:accept (l88)
-> AbstractArtifactHandler:accept (l126)
-> ...
-> AbstractArtifactHandler:accept (l136)
-> ...
-> Importer:commit (l1085)
-> Importer:commit (l1058)
-> Importer:commit (recursion)
-> Importer:run (l537)
-> ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
