On 11/06/15 14:35, Claude Warren wrote:
I'll have to go back and review the dependency tree.
The contract tests should only introduce:
1) a junit runner and associated annotations.
2) a maven mojo to report on the testing structure.
I think the client requirement comes in becaue there is a command line
version of the mojo. I'll see what I can do about extracting that into a
command line module separate from the main code -- shouldn't be hard.
As for the non-apache licensed pieces.... is there a way to generate a list
of them? All the xenei code is apache, the only other bits should be junit
and maven mojo depdendencies.
Claude
Hi Claude,
I looked at the output of "mvn dependency:tree" and for org.xenei,
org.mockito, here is an extract of output:
+- org.xenei:junit-contracts:jar:0.1.2:test
| +- commons-cli:commons-cli:jar:1.2:test
| \- commons-io:commons-io:jar:2.4:test
+- org.xenei:contract-test-maven-plugin:jar:0.1.2:test
| +- org.apache.maven:maven-plugin-api:jar:3.2.5:test
| | +- org.apache.maven:maven-model:jar:3.2.5:test
| | +- org.apache.maven:maven-artifact:jar:3.2.5:test
| | \- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.0.M1:test
| | +- javax.enterprise:cdi-api:jar:1.0:test
| | | \- javax.annotation:jsr250-api:jar:1.0:test
| | \- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.3.0.M1:test
| +- org.apache.maven:maven-core:jar:3.2.5:test
| | +- org.apache.maven:maven-settings:jar:3.2.5:test
| | +- org.apache.maven:maven-settings-builder:jar:3.2.5:test
| | +- org.apache.maven:maven-repository-metadata:jar:3.2.5:test
| | +- org.apache.maven:maven-model-builder:jar:3.2.5:test
| | +- org.apache.maven:maven-aether-provider:jar:3.2.5:test
| | | \- org.eclipse.aether:aether-spi:jar:1.0.0.v20140518:test
| | +- org.eclipse.aether:aether-impl:jar:1.0.0.v20140518:test
| | +- org.eclipse.aether:aether-api:jar:1.0.0.v20140518:test
| | +- org.eclipse.aether:aether-util:jar:1.0.0.v20140518:test
| | +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.2.3:test
| | | +- javax.inject:javax.inject:jar:1:test
| | | \- aopalliance:aopalliance:jar:1.0:test
| | +- org.codehaus.plexus:plexus-interpolation:jar:1.21:test
| | +- org.codehaus.plexus:plexus-utils:jar:3.0.20:test
| | +- org.codehaus.plexus:plexus-classworlds:jar:2.5.2:test
| | +- org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:test
| | \- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.3:test
| | \- org.sonatype.plexus:plexus-cipher:jar:1.4:test
| \- org.apache.maven:maven-compat:jar:3.2.5:test
| \- org.apache.maven.wagon:wagon-provider-api:jar:2.8:test
+- org.mockito:mockito-all:jar:1.9.5:test
On Thu, Jun 11, 2015 at 12:36 PM, Andy Seaborne <a...@apache.org> wrote:
On 19/05/15 20:25, Claude Warren wrote:
There is a set of contract tests (and test helpers) on the
"add-contract-tests" branch. That branch works and has minimal change
from
the current tests. Those changes are adding the junit-contract runner and
plugins.
It makes no change to the execution.
The problem that I am having is keeping it up to date with the current
change rate of the Jena packages. Granted the contract tests are only
implemented for the jena-core module, we have been keeing the entire suite
up to date.
Is there anyone that has any objection to moving the contract tests to the
main code branch?
Claude
Claude,
There are some rough edges:
1/ The POM has been converted from spaces to tabs around commit 608c2b4
2/ There are new dependencies, and recursive some are not Apache
Licensed. Is there anything that should go in LICENSE or NOTICE, even if
that comes via org.apache.maven?
3/ Why does testing depend on commons-cli?
PR#76 proposes use of commons:common-cli (different version)
which caused me to see that.
4/ Can we have version mgt in jena-parent please? All other version mgt
or non-jena dependencies is done there (jena-* ones have to be done
explicitly for the release plug-in)
Andy
