Qihong,

I hope the exams have gone well.

All of the tasks include "delivery" and it is this aspect we need to concentrate on now.

There needs to be:

1. Code and grammar changes
2. Tests
3. Pull requests
4. Documentation

I've looked through https://github.com/confidencesun/jena/commits/JENA-491.

(1) seems to progressing well.

For (2) I don't see tests in ARQ, whereas there should be execution and syntax test. There are 2 tests in Fusek2/TestQuery.

For (3), it is going to need some preparation.

There is a problem with the last (July 5) commit. At a guess, it looks like you updated the source code and committed it rather than merge the commits from Jena.

https://github.com/confidencesun/jena/commit/07afdbf0fe635d41c302b25a9c51f43802ea903a

There are 341 changed files.

Pull requests sent to apache/jena will need to be your code.

http://mail-archives.apache.org/mod_mbox/jena-dev/201507.mbox/%3C559EF342.3010806%40apache.org%3E

We need separate pull requests for jena-arq and one for jena-fuseki2. If we can start with jena-arq we can have review and refinement of that happening while work on pull requests for jena-fuseki2 happens.

Is there anymore work needed, except for tests, on the jena-arq module?

        Andy

Reply via email to