Hi Qihong, You're requried to keep us posted of your work progress regularly. Last week, there were some comments for your code ( PR 89 ) from the community. Have you read them and refined your code accordingly? Any questions?
Best regards, Ying Jiang On Tue, Jul 21, 2015 at 4:35 PM, Andy Seaborne <a...@apache.org> wrote: > On 21/07/15 17:46, Ying Jiang wrote: >> >> Hi Andy, >> >> Does Qihong need to be an apache committer in order to have the commit >> access? Can you grant her the access right? >> >> Best regards, >> Ying Jiang > > > When you press "Improve this page" it says > > "please use the username anonymous and leave the password blank if prompted > for credentials" > > > Before documentation makes sense, there needs to code updates. > This is most important. > > http://mail-archives.apache.org/mod_mbox/jena-dev/201507.mbox/%3C55ABD740.9010101%40apache.org%3E > > 1. Code and grammar changes > 2. Tests > 3. Pull requests > 4. Documentation > > http://mail-archives.apache.org/mod_mbox/jena-dev/201507.mbox/%3C559EF342.3010806%40apache.org%3E > > Andy > >> >> >> ---------- Forwarded message ---------- >> From: Qihong Lin <confidence....@gmail.com> >> Date: Tue, Jul 21, 2015 at 9:25 AM >> Subject: Fwd: Final Deliveries of GSoC Project (JENA-491) >> To: Ying Jiang <jpz6311...@gmail.com> >> >> >> Hi, Dr. Jiang, >> >> How can I have the commit access to the svn server? I also tried the >> "Improve this Page", which asked for user/password. >> >> The documentation seems to be wiki style. It's better to have preview >> of the doc when composing. The patch approach is not so convenient. >> >> >> regards, >> Qihong >> >> >> >> ---------- Forwarded message ---------- >> From: Bruno P. Kinoshita <ki...@apache.org> >> Date: Sun, Jul 19, 2015 at 5:52 AM >> Subject: Re: Final Deliveries of GSoC Project (JENA-491) >> To: "dev@jena.apache.org" <dev@jena.apache.org> >> >> >>> For 1), how to commit the documentation in Jena website? >> >> If you have commit access you can either edit the pages online by >> clicking on the link in the top right corner "Improve this Page", or >> check out the source repository at >> http://svn.apache.org/repos/asf/jena/site/trunk/ and commit your >> changes. >> >> Or you can check out the SVN repository, create a patch and attach it >> to a JIRA issue. >> >> Changes to the web site are visible initially in >> http://jena.staging.apache.org/ >> Hope that helpsBruno >> >> >> From: Qihong Lin <confidence....@gmail.com> >> To: dev@jena.apache.org >> Sent: Sunday, July 19, 2015 6:17 AM >> Subject: Re: Final Deliveries of GSoC Project (JENA-491) >> >> Hi, >> >> I've been taking some course exams for the last week. The current >> project status is ahead of plan. I'll continue the project next week >> after the exams. >> >> For 1), how to commit the documentation in Jena website? >> >> >> regards, >> Qihong >> >> >> >> On Wed, Jul 15, 2015 at 5:43 PM, Ying Jiang <jpz6311...@gmail.com> wrote: >>> >>> Hi Qihong, >>> >>> How is the project going? >>> >>> I've reviewed the code you committed last week. The function of Fuseki >>> support of constructing quad is generally OK. The tests make sense to >>> me, although just 2 tests. However, there's more deliveries for you >>> final work. At least, >>> >>> 1) Formal documentation of the goals, approaches, results and etc. >>> I suggest creating a doc page in jena website [1], in the section of >>> "Advanced SPARQL use" >>> >>> 2) Pull requests from your code base into apache/jena ASAP >>> Please split this up so that we can check your commits one by one. >>> More details in the other thread advised by Andy. >>> >>> 3) More tests for jena-arq and jena-fuseki-core following the original >>> framework >>> >>> Please let me know if anything forgotten. >>> >>> >>> Best regards, >>> Ying Jiang >>> >>> >>> [1] https://jena.apache.org/documentation/query/index.html > >
