[
https://issues.apache.org/jira/browse/JENA-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052733#comment-15052733
]
ASF GitHub Bot commented on JENA-1083:
--------------------------------------
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/106#discussion_r47353822
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/QuadTableForm.java ---
@@ -124,31 +96,21 @@ public PMapQuadTable get() {
return new PMapQuadTable(name()) {
@Override
- protected Quad quad(final Node s, final Node p,
final Node o, final Node g) {
- return Quad.create(g, s, p, o);
- }
+ public Quad tuple(final Quad q) {
+ return create(q.getSubject(), q.getPredicate(),
q.getObject(), q.getGraph());
--- End diff --
These criticisms are sadly accurate. I seem to have improved in one way by
creating other defects. I'm going to close this PR and see if I can solve the
problems I identified (repeated code, unclear responsibility) in a better,
tighter way, perhaps involving `ColumnMap`.
> MInor refactoring in TupleTables
> --------------------------------
>
> Key: JENA-1083
> URL: https://issues.apache.org/jira/browse/JENA-1083
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
> Reporter: A. Soroka
> Priority: Minor
>
> There are some minor refactorings available for TupleTable and its subtypes,
> particularly PMapTripleTable and PMapQuadTable that will clarify their use.
> Specifically, current impls of those abstract types have to override several
> methods for adding, removing, and finding tuples. In fact, the only
> information being added when those methods are overridden is conversion
> between canonical and internal tuple ordering. This refactoring is to provide
> methods that do that conversion and nothing else, which will make two methods
> the most that any implementation of those abstract classes will have to
> provide.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
