[
https://issues.apache.org/jira/browse/JENA-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071244#comment-15071244
]
ASF GitHub Bot commented on JENA-1083:
--------------------------------------
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/110#issuecomment-167159338
These are some fairly drastic to get `ColumnMap` to work here.
`Triple` and `Quad` are central classes used everywhere in Jena so the
implications are far ranging.
Are there cost implications? I'm not sure the compiler implications of
using arrays rather than object slots. For example, there are checks on array
access - sometime they can be removed, some times not. The objects are larger
by several slots.
And it all adds many new methods to Triple and Quad. They are tuple-like
but not full tuples (`Tuple` was not designed for this).
But Tuple of 3 is not a Triple. Different `.equals`.
I'm not clear this PR meets the objective of avoiding packing and
unpacking. There is implicit creation which I don't understand the implication
of via varargs parameters. e.g. `QuadOrdering.map(quad)` unpacks and calls the
varargs method.
What is more, the naming spills over into other parts it's less clear than
before: `first` is clearer than `nodes[0]` for example. While the original is
more verbose in places, it's repetitive (which is tested extensively now) to be
replaced by creating Tuples so it is not free. [I'm not sure that I actually
understand _find anyway.]
> MInor refactoring in TupleTables
> --------------------------------
>
> Key: JENA-1083
> URL: https://issues.apache.org/jira/browse/JENA-1083
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
> Reporter: A. Soroka
> Priority: Minor
>
> There are some minor refactorings available for TupleTable and its subtypes,
> particularly PMapTripleTable and PMapQuadTable that will clarify their use.
> Specifically, current impls of those abstract types have to override several
> methods for adding, removing, and finding tuples. In fact, the only
> information being added when those methods are overridden is conversion
> between canonical and internal tuple ordering. This refactoring is to provide
> methods that do that conversion and nothing else, which will make two methods
> the most that any implementation of those abstract classes will have to
> provide.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
