Github user afs commented on the pull request:

    https://github.com/apache/jena/pull/123#issuecomment-174309243
  
    As far as I can see, only an assembler solution will address 
[JENA-1122](https://issues.apache.org/jira/browse/JENA-1122). @bwmcbride - do 
you believe this PR alone will address JENA-1122? Has this PR been run under 
load?
    
    By protecting the text index alone, I see a new class of concurrency issues 
arising. A shared text index between two different TDB datasets will go wrong 
on update. At the moment, you can't create that setup because of JENA-1104. 
Other setups will have concurrency problems.
    
    *If* this works in a "one dataset, must be TDB, only in Fuseki" setup, it 
only protects against 
[JENA-1104](https://issues.apache.org/jira/browse/JENA-1104). If then use of 
TDB happens to work at the moment, it is based on internal implementation 
handling in Fuseki. That is very fragile. 
    
    This PR does no harm though it is a bit more complicated than needed 
because a solution to the root cause 
[JENA-1122](https://issues.apache.org/jira/browse/JENA-1122) may well remove 
the need for some of the machinery.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to