[ 
https://issues.apache.org/jira/browse/JENA-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125092#comment-15125092
 ] 

ASF GitHub Bot commented on JENA-1083:
--------------------------------------

Github user afs commented on the pull request:

    https://github.com/apache/jena/pull/120#issuecomment-177312482
  
    Merged after fixing up:
    
    1/ I used "git pull --no-commit" and got some compile errors (imports of 
`TriOperator.Operator3` etc) in files `SimpleMap*`. These classes are unused so 
I deleted them before commiting.
    
    2/ There were no licnese headers on `TConsumer3` etc. Please run `mvn clean 
test -Pdev` before submitting a pull request. This will run the license checks 
(also know as the RAT). Failing to pass RAT causes the maven build to fail.


> MInor refactoring in TupleTables
> --------------------------------
>
>                 Key: JENA-1083
>                 URL: https://issues.apache.org/jira/browse/JENA-1083
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: ARQ
>            Reporter: A. Soroka
>            Priority: Minor
>
> There are some minor refactorings available for TupleTable and its subtypes, 
> particularly PMapTripleTable and PMapQuadTable that will clarify their use. 
> Specifically, current impls of those abstract types have to override several 
> methods for adding, removing, and finding tuples. In fact, the only 
> information being added when those methods are overridden is conversion 
> between canonical and internal tuple ordering. This refactoring is to provide 
> methods that do that conversion and nothing else, which will make two methods 
> the most that any implementation of those abstract classes will have to 
> provide.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to