[
https://issues.apache.org/jira/browse/JENA-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106832#comment-15106832
]
ASF GitHub Bot commented on JENA-1083:
--------------------------------------
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-172877393
I'm happy to do whatever will get this merged and move on. I chose the
prefix names and not the numerical suffix names because that is what Java does
in (e.g.) `java.util.function.BiFunction` and I thought it was more important
to be in line with Java itself than any library. I'll add a commit with the
first proposal, although the use of a `T-` prefix seems really opaque. Without
the context of this discussion, it's not all obvious to me why `T-` would mean
"has the same type for all arguments".
As for `final`, I find `final` useful as an aid, not to the compiler, but
to humans, but I'm happy to write against any style standard at all, as long as
there is one. If "no `final` on interface params" is a rule, _please_ add it to
[the only documentation I know
of](https://jena.apache.org/getting_involved/reviewing_contributions.html#code-style)
for such things.
> MInor refactoring in TupleTables
> --------------------------------
>
> Key: JENA-1083
> URL: https://issues.apache.org/jira/browse/JENA-1083
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
> Reporter: A. Soroka
> Priority: Minor
>
> There are some minor refactorings available for TupleTable and its subtypes,
> particularly PMapTripleTable and PMapQuadTable that will clarify their use.
> Specifically, current impls of those abstract types have to override several
> methods for adding, removing, and finding tuples. In fact, the only
> information being added when those methods are overridden is conversion
> between canonical and internal tuple ordering. This refactoring is to provide
> methods that do that conversion and nothing else, which will make two methods
> the most that any implementation of those abstract classes will have to
> provide.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
