[
https://issues.apache.org/jira/browse/JENA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382471#comment-15382471
]
ASF GitHub Bot commented on JENA-1212:
--------------------------------------
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/157#discussion_r71170935
--- Diff:
jena-arq/src/main/java/org/apache/jena/atlas/data/SortedDataBag.java ---
@@ -200,9 +263,13 @@ public void flush()
if (!finishedAdding && memSize > 1)
{
// Again, some ugliness for speed
- Object[] array = memory.toArray();
- Arrays.sort(array, (Comparator)comparator);
- memory = Arrays.asList((E[])array);
+ E[] array = (E[]) memory.toArray();
+ if (comparator.abortableSort(array))
+ {
+ // if we comment this back in, we lose the timeout
message!
+ // return Iter.nullIterator();
+ }
--- End diff --
What's this?
> allow ORDER BY sort to be cancelled
> -----------------------------------
>
> Key: JENA-1212
> URL: https://issues.apache.org/jira/browse/JENA-1212
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
> Reporter: christopher james dollin
> Priority: Minor
> Fix For: Jena 3.1.1
>
>
> When a query with an ORDER BY is cancelled, the component
> Arrays.sort() that sorts the chunk(s) of the result
> bindings runs to completion before the cancel finishes.
> [See QueryIterSort and SortedDataBag.]
> For a large result set, this results in a long wait
> before the cancelled request finally finishes. This
> can be inconvenient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
