That's fine. The more important comment is on the main discussion page: there doesn't seem to be much use to `count` or `cancelTestFrequency` and I would get rid of both.
--- A. Soroka The University of Virginia Library > On Jul 19, 2016, at 10:28 AM, Chris Dollin <[email protected]> > wrote: > > On 19/07/16 15:18, ASF GitHub Bot (JIRA) wrote: > >> + >> + @Override public int compare(E o1, E o2) >> + { >> + count += 1; >> --- End diff -- >> >> I think this might read a bit better in the next line as: >> ``` >> if (++count % cancelTestFrequency == 0) > > I don't think squishing the increment into the test makes > it read any better, but am willing to go with the local style? > > Chris > > -- > "On this point the authors were for the most part vague." /Gaudy > Night/ > > Epimorphics Ltd, http://www.epimorphics.com > Registered address: Court Lodge, 105 High Street, Portishead, Bristol BS20 6PT > Epimorphics Ltd. is a limited company registered in England (number 7016688)
