Github user osma commented on the issue:

    https://github.com/apache/jena/pull/227
  
    Regarding merging, I would like to merge PR #226 first which changes the 
`TextIndex.query` method, breaking out the `lang` and `graph` information into 
separate parameters. The effect on this code should be that the `parse` method 
becomes unnecessary, but all the calls to the `query` method in the integration 
tests need to be changed slightly. I can do that myself, as I don't want to 
burden @anujgandharv anymore with extra work, but if you like you can switch 
your code on top of that branch already.
    
    Do people have opinions about whether to squash these (currently) 29 
commits into a single commit for `master`, or leave them as they are? It's a 
trade-off between historical accuracy and clarity. There have been quite a few 
back-and-forth changes in this branch. I would be inclined to squash and rebase 
before merging, making it clear what has actually changed in the jena-text 
code. The original commits should still be available in this PR in case anyone 
is interested in those. Opinions? @ajs6f? @afs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to