Github user dick-twocows commented on the issue:
https://github.com/apache/jena/pull/233
All the code if accepted needs to be properly annotated, I've removed the
original project specific annotations...
On 6 Apr 2017 3:39 pm, "A. Soroka" <notificati...@github.com> wrote:
> *@ajs6f* commented on this pull request.
> ------------------------------
>
> In jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/LockTry.java
> <https://github.com/apache/jena/pull/233#discussion_r110179015>:
>
> > @@ -0,0 +1,8 @@
> +package org.apache.jena.sparql.core.mosaic;
> +
> +import org.apache.jena.shared.Lock;
> +
> +public interface LockTry extends Lock {
> +
> + boolean tryEnterCriticalSection(boolean readLockRequested);
>
> It might be nice to put a Javadoc comment on this to make the required
> semantics precisely known. They seem clear now, but as Jena's concurrency
> evolves, they might get less so.
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/jena/pull/233#pullrequestreview-31332234>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ARAbAgpmThd8liNYmiMNV0JEf0xHJIeTks5rtPkCgaJpZM4M0qnn>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
