Github user kinow commented on a diff in the pull request:

    https://github.com/apache/jena/pull/114#discussion_r183974343
  
    --- Diff: jena-arq/Grammar/master.jj ---
    @@ -2176,6 +2251,19 @@ String String() : { Token t ; String lex ; }
         }
     }
     
    +#ifdef ARQ
    +Number Number() : { Token t ; Number number ; }
    +{
    +  (
    +    t = < INTEGER > { number = integerValue(t.image) ; }
    +  | t = < DECIMAL > { number = doubleValue(t.image) ; }
    --- End diff --
    
    @afs nice catch in that observation. Reduced code duplication and avoids 
now possible "forgot to apply to the other part of the json clause" issues in 
the future :-)
    
    Change applied. Rebased, ran all tests, tried three queries mentioned in 
this pull request (we have a few already! :smiley: ), got no issues.
    
    Pushing the latest code, rebased onto the maste branch.


---

Reply via email to