Github user kinow commented on a diff in the pull request:

    https://github.com/apache/jena/pull/114#discussion_r184639752
  
    --- Diff: 
jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java 
---
    @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query)
             out.print("ASK") ;
             out.newline() ;
         }
    -    
    +
    +    @Override
    +    public void visitJsonResultForm(Query query) {
    +        out.print("JSON {");
    +        List<String> terms = new ArrayList<>();
    +        for (Map.Entry<String, Object> entry : 
query.getJsonMapping().entrySet()) {
    --- End diff --
    
    > Just use incIndent twice!
    
    Haha, I like it. Done!
    
    >Is it ready to merge? Any area to look at specially? I've used qparse on 
JSON queries and run a few test queries with all the cases I can think of.
    
    I think so ! Only minor thing on my mind now are some expressions. We have 
not implemented support for queries with expressions like
    
    `JSON { 'F' : sum(1+2)} WHERE { } `
    
    Or other functions. Perhaps that could - if necessary - be implemented 
later?


---

Reply via email to