Github user lewismc commented on a diff in the pull request:
https://github.com/apache/jena/pull/474#discussion_r222164161
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
<version>3.10.0-SNAPSHOT</version>
</dependency>
- <!-- Jena Driver configures Log4j directly -->
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
- </dependency>
+ <!-- Jena Driver configures Log4j directly -->
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ </dependency>
+
+ <dependency>
--- End diff --
Ok thanks @rvesse. The logic seems clear from what you wrote, it doesn't
however take away from the fact that the codebase will not build under JDK10
(and possibly JDK9) without the presence of the log4j library containing
org.apache.log4j.PropertyConfigurator as currently used within
jena/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java.
The issue here is to either refactor the logging or to add the
dependency... I would think there is no other scenario under consideration.
Is that a fair statement?
---
