Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/474#discussion_r222243798
  
    --- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
    @@ -39,17 +39,28 @@
                        <version>3.10.0-SNAPSHOT</version>
                </dependency>
     
    -    <!-- Jena Driver configures Log4j directly -->
    -    <dependency>
    -      <groupId>org.slf4j</groupId>
    -      <artifactId>slf4j-log4j12</artifactId>
    -    </dependency>
    +           <!-- Jena Driver configures Log4j directly -->
    +           <dependency>
    +                   <groupId>org.slf4j</groupId>
    +                   <artifactId>slf4j-log4j12</artifactId>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>log4j</groupId>
    +                   <artifactId>log4j</artifactId>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>org.apache.logging.log4j</groupId>
    +                   <artifactId>log4j-api</artifactId>
    +           </dependency>
    +
    +           <!-- Intercept direct use of log4j2 -->
    +           <dependency>
    +                   <groupId>org.apache.logging.log4j</groupId>
    --- End diff --
    
    More:
    
    Confirmed I have only have to add a single log4j1 dependency.
    The error is otherwise from the maven-javadoc-plugin, not the compiler:
    
    ```
    [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadocs) on 
project jena-jdbc-driver-bundle: MavenReportException: Error while generating 
Javadoc: 
    [ERROR] Exit code: 1 - 
/home/afs/Jena/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java:42:
 error: package org.apache.log4j does not exist
    [ERROR] import org.apache.log4j.PropertyConfigurator;
    [ERROR]                        ^
    [ERROR] 
    [ERROR] Command line was: /usr/lib/jvm/default-java/bin/javadoc @options 
@packages
    [ERROR] 
    [ERROR] Refer to the generated Javadoc files in 
'/home/afs/Jena/jena-jdbc/jena-jdbc-driver-bundle/target/apidocs' dir.
    [ERROR] 
    ```


---

Reply via email to