Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/474#discussion_r222399187
  
    --- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
    @@ -39,17 +39,28 @@
                        <version>3.10.0-SNAPSHOT</version>
                </dependency>
     
    -    <!-- Jena Driver configures Log4j directly -->
    -    <dependency>
    -      <groupId>org.slf4j</groupId>
    -      <artifactId>slf4j-log4j12</artifactId>
    -    </dependency>
    +           <!-- Jena Driver configures Log4j directly -->
    +           <dependency>
    +                   <groupId>org.slf4j</groupId>
    +                   <artifactId>slf4j-log4j12</artifactId>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>log4j</groupId>
    +                   <artifactId>log4j</artifactId>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>org.apache.logging.log4j</groupId>
    +                   <artifactId>log4j-api</artifactId>
    +           </dependency>
    +
    +           <!-- Intercept direct use of log4j2 -->
    +           <dependency>
    +                   <groupId>org.apache.logging.log4j</groupId>
    --- End diff --
    
    Wrong PropertyConfigurator.java  - there are two, one in log4j1 and one in 
log4j2 for compatibility code 
`log4j-1.2-api/src/main/java/org/apache/log4j/PropertyConfigurator.java`.
    
    Jena is picking up the one from log4j1. So the log4j2 dependencies aren't 
need but the log4j1 is. Either will do to compile but log4j1 is intended.



---

Reply via email to