Perhaps we could modify the search box slightly to get rid of the need for the clear search results button?
The following could be done: 1. Search box gets a "Clear Results" button. 2. On enter, Search box doesn't exit. 3. Clear Results button would be disabled until their are results to clear. This would also set us up for a possible future search enhancement to allow for previous/next buttons in the search box to shuffle through the search results interactively(instead of a simply highlight). Thoughts? Anthony On Thu, Jan 19, 2012 at 1:34 PM, sebb <[email protected]> wrote: > On 19 January 2012 18:28, Milamber <[email protected]> wrote: > > On Thu, Jan 19, 2012 at 6:10 PM, sebb <[email protected]> wrote: > > > >> On 19 January 2012 17:54, Milamber <[email protected]> wrote: > >> > On Thu, Jan 19, 2012 at 5:47 PM, sebb <[email protected]> wrote: > >> > > >> >> On 19 January 2012 16:36, Anthony Johnson <[email protected]> wrote: > >> >> > Hi Milamber, > >> >> > I will debug the Search button issues and file a bug if they > still > >> >> occur > >> >> > today(OSX 10.7.2/JDK 1.6.0_29) > >> >> > > >> >> > Since no work is occurring on this area, I will work on some of my > >> >> > improvements and submit via patches. > >> >> > > >> >> > For the icons, I can't help(no graphic skills:-(, but they are the > >> focal > >> >> > point when the GUI is first launched and I don't think they give a > >> good > >> >> > first impression to the user. Could we re-use icons from something > >> like > >> >> > the Open Icon Library?( > >> http://sourceforge.net/projects/openiconlibrary/) > >> >> > >> >> Depends on the license for the particular icons. > >> >> > >> > > >> > > >> > I think the icons set "open_icon_library-CC" can be used for changes > >> > toolbar icons. > >> > > >> > http://openiconlibrary.sourceforge.net/LICENSES.html > >> > > >> > "open_icon_library-CC (Creative Commons and Public Domain > only) > >> > List of licenses used in these packages: > >> > Creative Commons Attribution > >> > Creative Commons Attribution-Share Alike > >> > Public Domain" > >> > > >> > In : > >> > http://www.apache.org/legal/resolved.html#category-a > >> > "Creative Commons Attribution (CC-A)" > >> > > >> > and : > >> > > >> > http://www.apache.org/legal/resolved.html#can_works_placed_in_the_public_domain_be_included_in_apache_products > >> > "Works in the public domain (or covered by a license treated > similarly) > >> > may be included within Apache products. Attribution is required (in a > >> > similar fashion to permissive licenses)." > >> > > >> > Seb, can you confirm my reading? > >> > >> Yes, that set of licenses should be OK. > >> > > > > > > Thanks. > > With this licenses, I think that I can modify a icon to create a new > icon? > > (like add a broom on binoculars to symbolize "clean search") > > Probably not: > > http://www.apache.org/legal/resolved.html#cc-sa > > > Milamber > > > > > >> > >> > I will try to use some icons from > >> > open_icon_library-CC/icons/png/32x32/actions to improve toolbar icon > >> > > >> > Milamber > >> > > >> > > >> > > >> > > >> > > >> >> > >> >> > Thanks, > >> >> > > >> >> > Anthony > >> >> > > >> >> > On Thu, Jan 19, 2012 at 2:44 AM, Milamber <[email protected]> > >> wrote: > >> >> > > >> >> >> Hello, > >> >> >> > >> >> >> Le 19/01/2012 04:56, Anthony Johnson a ecrit : > >> >> >> > Hey Guys, > >> >> >> > I just built trunk for the first time in awhile and the > >> >> on-by-default > >> >> >> > toolbar could use some work. > >> >> >> > > >> >> >> > -- icons are kinda 8-bit windowish > >> >> >> > > >> >> >> > >> >> >> Yes, icons comes from src/core/org/apache/jmeter/images, which > are a > >> old > >> >> >> set of icons. > >> >> >> If you have a new set of icons with better design/quality, we are > >> >> >> interested. > >> >> >> > >> >> >> > -- Reset Search doesn't work > >> >> >> > > >> >> >> Works for me. > >> >> >> (Debian 6 with JDK 5/6, Windows XP with JDK 6) > >> >> >> > >> >> >> > -- Search button doesn't work again until Reset Search is > called. > >> >> >> > > >> >> >> > >> >> >> Works too. > >> >> >> > >> >> >> > -- Why do we have a close and a new? They seem to do the same > >> thing? > >> >> >> > > >> >> >> > >> >> >> Yes same action. I think that have a New and Close allow a better > >> user > >> >> >> friendly for JMeter users (particular for new users). Theses icons > >> are > >> >> >> "traditional" in a toolbar and permit to new people to have some > >> marks > >> >> >> > >> >> >> > -- Some buttons/Actions could be simplified(merge Start/Stop > icons) > >> >> >> > > >> >> >> > >> >> >> Yes, possibly. > >> >> >> > >> >> >> > Is this feature still being worked or should I be opening bugs > for > >> >> these > >> >> >> > items? > >> >> >> > > >> >> >> > >> >> >> Currently, no works planned. > >> >> >> > >> >> >> Milamber > >> >> >> > >> >> >> > Thanks, > >> >> >> > > >> >> >> > Anthony > >> >> >> > > >> >> >> > > >> >> >> > >> >> >> > >> >> > >> >
