Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/358
Hi @ham1 ,
Thanks for this PR.
Unfortunately I am not very comfortable with PR that touch a lot of file
and where the code modification may touch more things than what the PR
describes.
Would it be possible to rebase your PR and split it into at max 10 files ?
It is easier to review and merging is faster for me, which will mean I'll
merge it earlier and you won't have to rebase.
Also if possible, try to make the PR really only touch what it pretends to.
Sonar fixes might sometimes break existing code so they need careful review
and merge.
Thanks a lot again for all your work !
Regards
---
