On Mon, 25 Feb 2019 at 18:24, Vladimir Sitnikov <[email protected]> wrote: > > sebb> The 5.2-SNAPSHOT builds will hang around unless manually deleted > > It will be superseded by CI automatically as soon as the vote passes and > the version is incremented to 5.2-SNAPSHOT.
Yes - in general. But this may take days, weeks or even months. It has done in the past. Or 5.2-SNAPSHOT may never be replaced, if the next version is 6.0-SNAPSHOT. As I recall, there was an issue with the wrong snapshot being used that led to the current process being introduced. We've not had the issue since. > 1) As far as I read the discussion, no-one really cares of the past tags, That's not the case; past tags that relate to releases and release votes are vital and must be preserved. > so I'm fine with just leaving tag placement "as is". > > 2) I'm inclined to drop docs/ folder from the source repository. It should > better be placed to the separate site repository. Sounds OK, but might make it harder to build the site. At present the source for the site is in the same directory tree as the output, which means it can easily be found as a relative path. If the output is in a different repo then it will be in a different directory structure. How do you get from one to the other? I think this needs careful consideration. > 3) I'm inclined to drop "test-bin" and "testhead" tags. The sad thing with > "testhead" is that tag has its own "root commit" somehow. What do you mean by "root commit"? It looks just like the other test* tags to me. > Those tags are not important anyway. Agreed. The following are SVN test commits, and could be deleted now: tags/test tags/test-bin tags/test1157668 tags/testhead > Then docs-x.y branches are pretty-much harmless. The only annoying thing is > the number of the branches, however it is manageable. > > Here's the preview repo: https://github.com/vlsi/jmeter-git-cleanup-result > > There's consistency issue with branch and tag naming. > For instance: > rel-2_0_0 > rel-2_1 > doc-v2_3_1 > docs-2.4 > docs-5.1 > > tags/v5_1 > > Frankly speaking, I would prefer to name release branches as > release-$VERSION, and name tags as v$VERSION. > For instance: release-5.1 branch and v5.1 tag. > > Of course we can't just rename old tags (since people might rely on that > naming), however we could create v5.1 kind of tags for each v5_1, and we > can use v5.2, and so on later. > What do you think? I agree it would be better if there had be a proper naming convention from the start. However it is too late to fix discrepancies now. Also it will be confusing to have duplicate tags just to fix the names. I would ignore the earlier discrepancies but document and then stick to the current convention going forward. > "docs-" branch name is misleading, as it effectively used as a release > branch for a specific version. Again, IMO it's too late to change this now. > Vladimir
