On Mon, 27 May 2019 at 21:59, Vladimir Sitnikov <[email protected]> wrote: > > sebb> -1, because that loses all the SVN history. > > I'm afraid you are wrong. Could you please clarify what do you mean?
I meant that the Git repo would lose the SVN history. > Note: SVN repository is NEVER killed. It would still be around in read-only > mode. Obviously. > sebb> AFAICT, there is no way to find historic SVN revisions in the > cleaned-up repo > > SVN revision numbers (and branch names) are present in commit messages. > For instance: > https://github.com/vlsi/jmeter-git-cleanup-result/commit/561048407dab3afcfd880b168fabdeeeabb8422d > > There are two references: > 1) Reference to SVN: git-svn-id: > https://svn.apache.org/repos/asf/jmeter/trunk@1860117 > 2) Reference to "old Git mirror": Former-commit-id: > 184a9d5a5ea8badd1b1616dad0ff2f327a9b0756 OK, not sure how I missed that. > sebb> Also, where in the history are the files that have been deleted? > > The deleted files are still available via SVN read-only mirror. But not in the Git history. I think Infra need to agree to that. > sebb> I think INFRA need to review the script to make sure that it preserves > sebb> all necessary provenance. > > Great note, indeed. That is up to them though. I don't think we can do much > here. We need to ask Infra to agree the process. > sebb> -1 to combining Git with Gradle for the reasons stated above. > > What about the use of https://github.com/vlsi/jmeter-git-cleanup-result for > Git? > It looks like the only your concerns were "missing SVN revisions" (which > are present) and "lost files" (which will be available through read-only > SVN). > I read that as you have no concerns regarding jmeter-git-cleanup-result > besides the one that INFRA should check that somehow. No, that is not what I wrote. I noted two issues with the Git repo. I did not look at the git repo any further once I had noted those two because I thought they were serious enough for it to be pointless to check further. One issue (svn ids) was invalid, but the other still applies, i.e. is Infra OK with dropping files during conversion? I don't know whether there are other issues with the repo. A separate matter is that I believe Infra should review the script that was used to create the repo in case they have any concerns. > Vladimir
