On Tue, 28 May 2019 at 15:48, Vladimir Sitnikov <[email protected]> wrote: > > sebb>Infra OK with dropping files during conversion? > > As you can see, the very same bfg.jar has already been used to cleanup the > repository size: https://issues.apache.org/jira/browse/INFRA-7464 > I believe that makes the cleanup approach perfectly viable.
Note that those JIRAs had agreement from Infra. > In other words, none of your "serious enough" issues hold anymore. Not so: we don't yet know what Infra have to say. > sebb>I don't know whether there are other issues with the repo. > > Apparently INFRA does not know which files are important and which are not > for JMeter project, so they won't be able to tell if the script removes > more than necessary. The issue is whether INFRA agree that is OK to delete any files during the conversion. We don't yet know that. > On the other hand, the script is straightforward, and it uses well-known > tools rm -rf is a well-known tool; what matters is how the tool is used and the end result. > so it is very unlikely INFRA would deny the use of that script. It may be unlikely, but INFRA need to give their view on the proposed conversion process. > That being said, we can just proceed with the analysis of > https://github.com/vlsi/jmeter-git-cleanup-result repository. > > Note: in the meantime I updated the conversion script so it no longer > removes png files from xdocs folder. "cleanup-result" repository is updated > as well. So what else has been dropped from the output? I think you need to update the JIRA with the hashes of the tool and the repo so Infra have a stable base to look at. > Vladimir
